Skip to content

fix: directory with forward slash exists on windows #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2025
Merged

fix: directory with forward slash exists on windows #759

merged 5 commits into from
Mar 13, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Mar 9, 2025 •
edited
Loading

@vbreuss vbreuss added the bug Something isn't working label Mar 9, 2025
@vbreuss vbreuss self-assigned this Mar 9, 2025
@github-actions
Copy link

github-actions bot commented Mar 9, 2025 •
edited
Loading

Test Results

     52 files  ±  0       52 suites  ±0   23m 7s ⏱️ -4s
 58 650 tests + 14   55 620 ✅ + 15   3 030 💤 ±0  0 ❌  - 1 
121 770 runs  +141  109 139 ✅ +142  12 631 💤 ±0  0 ❌  - 1 

Results for commit 10cd8e7. ± Comparison against base commit 67a6567.

This pull request removes 50774 and adds 50788 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path049d490b-48bd-4ce2-a4e1-d8151006ccb3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0e430705-558a-4e91-87c0-b23b6a4f9cad")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path149d1cd9-ad0f-46d7-8142-9d253be33f81")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path25fdc8a8-099d-442e-85d1-1c035935d402")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path561cd969-c1de-4d43-a89e-53e13b125955")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path78d02649-4298-4241-a575-754c6af22fe5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path99c03acd-c567-4988-ad50-86752399f4d3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbd733c2f-e699-4e4b-8245-627a9f566b77")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathc33f9e92-50bb-4a9c-90e8-9bdbe55fc003")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd4ec88f2-64a8-4558-8f86-d065a1596a1f")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0671e52b-de9b-48ef-b777-14955bde1750")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0e5385e5-921e-4b68-98a3-91abd9c23e62")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1a176cda-568f-4f8b-9553-f3e92e935a15")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path289d1b0f-6799-4505-85cc-ce669765585a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path572f8990-8d4a-4701-b4d2-dbba47c49ef3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6ff10ea8-d181-4369-b123-809ae6b817bc")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7cdca78c-39e6-441e-84d1-7973da8d1355")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path942ead33-c7f2-41a0-adc8-e133c9a59bb6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd87889a3-677c-4d05-85dd-8e48443b17af")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe333f06d-d6a0-45ad-9d9f-a0afc5a7a573")
…
This pull request removes 2411 skipped tests and adds 2411 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0e430705-558a-4e91-87c0-b23b6a4f9cad")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path149d1cd9-ad0f-46d7-8142-9d253be33f81")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path25fdc8a8-099d-442e-85d1-1c035935d402")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path561cd969-c1de-4d43-a89e-53e13b125955")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path78d02649-4298-4241-a575-754c6af22fe5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path99c03acd-c567-4988-ad50-86752399f4d3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path28c3127f-cac5-4490-ab5d-f981ed76fe8f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2ef3c70d-3b09-4447-9bb2-2bd9bb00c5bb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathb1979bd0-2167-4b8c-8e41-431bd21f2a21")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbc93288b-5ecd-4a2b-8d1e-143e64e2a597")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1a176cda-568f-4f8b-9553-f3e92e935a15")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path289d1b0f-6799-4505-85cc-ce669765585a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path572f8990-8d4a-4701-b4d2-dbba47c49ef3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path942ead33-c7f2-41a0-adc8-e133c9a59bb6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd87889a3-677c-4d05-85dd-8e48443b17af")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe333f06d-d6a0-45ad-9d9f-a0afc5a7a573")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path086467a1-1b08-4e60-ad87-04088fcdca5c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1561e7cb-468a-4918-9ed4-caa9661a3c48")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path33d807b0-74c3-45a7-932c-d937b71cd521")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3bc8cb64-1459-43d3-ac94-8d6a80ef3ae7")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss force-pushed the topic/fix-directory-exists-with-forward-slash branch from 757199e to ddca44b Compare March 13, 2025 07:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss merged commit 113ee6c into main Mar 13, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/fix-directory-exists-with-forward-slash branch March 13, 2025 11:37
@github-actions
Copy link

github-actions bot commented Mar 13, 2025

This is addressed in release v4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

bug Something isn't working state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss